Fixes to PAJ7620 driver and code sample #93044
Open
+58
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
asemjonovs,
avisconti,
jeppenodgaard,
MaureenHelm,
nashif,
teburd,
tristan-google,
ubieda and
yperess
|
cc @paultimke |
kartben
changed the title
faxe1008
previously approved these changes
Jul 12, 2025
MaureenHelm
reviewed
Jul 15, 2025
| LOG_MODULE_REGISTER(paj7620, CONFIG_SENSOR_LOG_LEVEL); | ||
| LOG_MODULE_REGISTER(paj7620_trigger, CONFIG_SENSOR_LOG_LEVEL); |
There was a problem hiding this comment.
Is there a reason not to use LOG_MODULE_DECLARE?
There was a problem hiding this comment.
duh, of course - Fixed, thanks!
paj7620 log module was being registered twice ; use LOG_MODULE_DECLARE instead in paj7620_trigger.c Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
The current sample was always trying to enable trigger mode in the driver no matter what, causing issues for instances where the sensor simply has no interrupt pin configured in Devicetree. Cleaned things up so that enabling trigger mode is done via the driver's Kconfig option, and cleaned up the Twister testcases accordingly (plus, made sure they are actually built by setting min_ram to a value compatibel with the nucleo_f334r8). README has also been updated to clearly document how to enable either mode. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.